ci: find liblzma >= 5.6.3 on windows msvc tests#2421
Merged
kientzle merged 1 commit intolibarchive:masterfrom Dec 7, 2024
Merged
ci: find liblzma >= 5.6.3 on windows msvc tests#2421kientzle merged 1 commit intolibarchive:masterfrom
kientzle merged 1 commit intolibarchive:masterfrom
Conversation
kientzle
approved these changes
Dec 4, 2024
Contributor
|
Looks good! Let me know when you think this is ready to merge. |
Contributor
Author
|
Unfortunately this isn't working yet :( I'm testing elsewhere at the moment- I might need to file and issue in the xz-utils repository to figure this out. |
We currently use XZ Utils 5.6.3 on windows CI jobs, but the Windows (msvc) job which uses cmake seems to only be looking for the old library name, liblzma.lib: ``` -- Looking for lzma_auto_decoder in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_auto_decoder in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Looking for lzma_easy_encoder in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_easy_encoder in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Looking for lzma_lzma_preset in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_lzma_preset in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Could NOT find LibLZMA (missing: LIBLZMA_HAS_AUTO_DECODER LIBLZMA_HAS_EASY_ENCODER LIBLZMA_HAS_LZMA_PRESET) (found version "5.6.3") ``` We need to update build/ci/github_actions/ci.cmd to look for lzma.lib instead.
mostynb
force-pushed
the
windows_lzma_cmake_fix
branch
from
dd2bda5 to
e905c0f
Compare
mostynb
changed the title
Contributor
Author
|
I think this is ready, but it turned out to be an issue in build/ci/github_actions/ci.cmd instead, therefore re-requesting a review. |
kientzle
approved these changes
Dec 7, 2024
mmatuska
pushed a commit
to mmatuska/libarchive
that referenced
this pull request
Dec 29, 2024
We currently use XZ Utils 5.6.3 on windows CI jobs, but the Windows (msvc) job which uses cmake seems to only be looking for the old library name, liblzma.lib: ``` -- Looking for lzma_auto_decoder in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_auto_decoder in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Looking for lzma_easy_encoder in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_easy_encoder in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Looking for lzma_lzma_preset in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_lzma_preset in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Could NOT find LibLZMA (missing: LIBLZMA_HAS_AUTO_DECODER LIBLZMA_HAS_EASY_ENCODER LIBLZMA_HAS_LZMA_PRESET) (found version "5.6.3") ``` We need to update build/ci/github_actions/ci.cmd to look for lzma.lib instead. (cherry picked from commit 9b7540a)
mmatuska
pushed a commit
to mmatuska/libarchive
that referenced
this pull request
Mar 11, 2025
We currently use XZ Utils 5.6.3 on windows CI jobs, but the Windows (msvc) job which uses cmake seems to only be looking for the old library name, liblzma.lib: ``` -- Looking for lzma_auto_decoder in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_auto_decoder in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Looking for lzma_easy_encoder in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_easy_encoder in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Looking for lzma_lzma_preset in C:/Program Files (x86)/xz/lib/liblzma.lib -- Looking for lzma_lzma_preset in C:/Program Files (x86)/xz/lib/liblzma.lib - not found -- Could NOT find LibLZMA (missing: LIBLZMA_HAS_AUTO_DECODER LIBLZMA_HAS_EASY_ENCODER LIBLZMA_HAS_LZMA_PRESET) (found version "5.6.3") ``` We need to update build/ci/github_actions/ci.cmd to look for lzma.lib instead. (cherry picked from commit 9b7540a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently use XZ Utils 5.6.3 on windows CI jobs, but the Windows (msvc)
job which uses cmake seems to only be looking for the old library name,
liblzma.lib:
We need to update build/ci/github_actions/ci.cmd to look for lzma.lib instead.