Updates for client re-factor#597
Merged
evoskuil merged 1 commit intolibbitcoin:masterfrom Sep 17, 2018
Merged
Conversation
thecodefactory
force-pushed
the
client-refactor
branch
from
f6e94af to
99c8019
Compare
thecodefactory
force-pushed
the
client-refactor
branch
from
99c8019 to
9b3bc79
Compare
evoskuil
approved these changes
Sep 17, 2018
Member
evoskuil
left a comment
evoskuil
left a comment
There was a problem hiding this comment.
All tests passing on VS. I haven't looked at the code, but feel free to merge when ready.
thecodefactory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress
-- I think it can be simplified more too (particularly with the error checking now added to every handler), but shows the basic idea.Watch and subscribe commands are not working, butenough is shown to see the basic API changes for working with changes proposed in libbitcoin/libbitcoin-client#234I'll cancel the travis build since it can't complete without the client PR.