Skip to content

Eliminate unnecessary method name copy in send_notification(). #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Apr 21, 2026
+7 −7
Merged

Eliminate unnecessary method name copy in send_notification(). #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/bitcoin/network/channels/channel_rpc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class channel_rpc
result_handler&& handler) NOEXCEPT;
inline void send_result(rpc::value_t&& result, size_t size_hint,
result_handler&& handler) NOEXCEPT;
inline void send_notification(const rpc::string_t& method,
inline void send_notification(rpc::string_t&& method,
rpc::params_t&& notification, size_t size_hint,
result_handler&& handler) NOEXCEPT;

Expand Down
4 changes: 2 additions & 2 deletions include/bitcoin/network/impl/channels/channel_rpc.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,15 +241,15 @@ inline void CLASS::send_result(rpc::value_t&& result, size_t size_hint,
}

TEMPLATE
inline void CLASS::send_notification(const rpc::string_t& method,
inline void CLASS::send_notification(rpc::string_t&& method,
rpc::params_t&& notification, size_t size_hint,
result_handler&& handler) NOEXCEPT
{
BC_ASSERT(stranded());
send(rpc::request_t
{
.jsonrpc = version_,
.method = method,
.method = std::move(method),
.params = std::move(notification)
}, size_hint, std::move(handler));
}
Expand Down
6 changes: 3 additions & 3 deletions include/bitcoin/network/impl/protocols/protocol_rpc.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ inline void CLASS::send_result(rpc::value_t&& result, size_t size_hint,
}

TEMPLATE
inline void CLASS::send_notification(const rpc::string_t& method,
inline void CLASS::send_notification(rpc::string_t&& method,
rpc::params_t&& notification, size_t size_hint,
result_handler&& handler) NOEXCEPT
{
channel_->send_notification(method, std::move(notification), size_hint,
std::move(handler));
channel_->send_notification(std::move(method), std::move(notification),
size_hint, std::move(handler));
}

} // namespace network
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/network/protocols/protocol_rpc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class protocol_rpc
result_handler&& handler) NOEXCEPT;
virtual inline void send_result(rpc::value_t&& result, size_t size_hint,
result_handler&& handler) NOEXCEPT;
virtual inline void send_notification(const rpc::string_t& method,
virtual inline void send_notification(rpc::string_t&& method,
rpc::params_t&& notification, size_t size_hint,
result_handler&& handler) NOEXCEPT;

Expand Down