Skip to content

Add bs-litecoin.cfg to data. #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add bs-litecoin.cfg to data. #487

wants to merge 1 commit into from

Conversation

@toxeus
Copy link
Contributor

@toxeus toxeus commented Sep 12, 2018

This concludes litecoin support.

@toxeus toxeus requested a review from evoskuil September 12, 2018 13:05
@toxeus
Add bs-litecoin.cfg to data.
f9ca025 
This concludes litecoin support.
@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage remained the same at ?% when pulling f9ca025 on toxeus:cfg into 7f320bd on libbitcoin:master.

evoskuil
evoskuil reviewed Sep 12, 2018
View reviewed changes
Copy link
Member

@evoskuil evoskuil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not ship a config file for every coin/context. We used to do this for testnet. This gets really hard to manage over time. My preference is to maintain the differences from defaults in the wiki (as we do now for testnet and regtest).

@toxeus
Copy link
Contributor Author

toxeus commented Sep 12, 2018

Alright.

@toxeus toxeus closed this Sep 12, 2018
@toxeus toxeus deleted the cfg branch September 12, 2018 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evoskuil evoskuil evoskuil left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@toxeus @coveralls @evoskuil