Inline kernel build into test-coverage job#1543
Merged
d-e-s-o merged 1 commit intolibbpf:mainfrom Apr 15, 2026
Merged
Conversation
With recent changes, the build-linux action outputs the build directory path directly instead of uploading an artifact. Since it is a composite action, its steps run in the caller's job and the build directory is already on disk. Inline the build-linux step into the test-coverage job, removing the separate build-linux-kernel job along with the artifact download via curl. Doing so simplifies things a bunch and eliminates the scheduling issues we have seen where build-linux-kernel, despite being on the critical path, was sometimes scheduled to run only after a bunch of other jobs, which artificially worsened total job runtime. Signed-off-by: Daniel Müller <deso@posteo.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1543 +/- ##
==========================================
+ Coverage 95.50% 95.51% +0.01%
==========================================
Files 56 56
Lines 9534 9534
==========================================
+ Hits 9105 9106 +1
+ Misses 429 428 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes, the
build-linuxaction outputs the build directory path directly instead of uploading an artifact. Since it is a composite action, its steps run in the caller's job and the build directory is already on disk.Inline the
build-linuxstep into thetest-coveragejob, removing the separatebuild-linux-kerneljob along with the artifact download via curl. Doing so simplifies things a bunch and eliminates the scheduling issues we have seen wherebuild-linux-kernel, despite being on the critical path, was sometimes scheduled to run only after a bunch of other jobs, which artificially worsened total job runtime.