Merged
Conversation
tstack
reviewed
Sep 17, 2019
Contributor
tstack
left a comment
tstack
left a comment
There was a problem hiding this comment.
It might also be helpful to have some functions to cover the general classes of errors, like is_client_error() for the 4XX range and is_server_error() for the 5XX range.
Contributor
|
thanks! |
|
Great addition. I have found that status reason important especially to the user. There is this code[1] here under CC0. Should we add it to library so that when we get status code we can request reason to display to user for example? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't find status codes in the library so I scrapped them from https://developer.mozilla.org/en-US/docs/Web/HTTP/Status