Merged
Conversation
A TTLSeconds of `0` is valid within Unifi and represents "auto".
Collaborator
|
Thanks for the contribution! LGTM 👍🏽 |
Collaborator
|
@harrisonhjones I did not notice at first but your change broke the creation of some record types (the ones that do not support TTL). I fixed it by setting the TTL to omitempty again but when no value was set, default it to 0. That way the record types that need it always have a number |
Contributor
Author
|
Neat. I figured that my change might have side effects; thanks for catching those so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this great library.
Why & Why
While playing around with it today I noticed I could not create records with an
autottl. I was getting:When I tried:
This change removes the
omitemptyfrom the JSON struct tag so that0s are still marshalled to JSON correctly.Testing
I made this change locally and then tried the above code snippet. It created the new record successfully. I checked the unifi console and I saw the new record with an
autoTTL.