Rewrite Function.__init__()#240
Merged
avalentino merged 1 commit intoliberfa:mainfrom May 5, 2026
Merged
Conversation
The `cfunc` and `ret` attributes of `Function` instances were only used in `Function.__init__()`, so there was no reason to have them as attributes. Additionally, if `Function.__init__()` cannot find the function definition (but it can find the file that should contain it) then the error it raises is now much more informative.
avalentino
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason for editing
Function.__init__()was that thecfuncandretattributes ofFunctioninstances were never used outside__init__()so there was no reason to store them. Then it turned out thatcfunccould be eliminated entirely with better regexes, and then I ended up rewriting the entire thing. The changes do not cause any differences in the fileserfa_generatorcreates.