Simplify extracting argument names from C doc comments#244
Merged
avalentino merged 1 commit intoliberfa:mainfrom May 7, 2026
Merged
Simplify extracting argument names from C doc comments#244avalentino merged 1 commit intoliberfa:mainfrom
avalentino merged 1 commit intoliberfa:mainfrom
Conversation
Previously when `FunctionDoc._get_arg_doc_list()` extracted arguments from C doc comments it also extracted struct fields, which then had to be removed after the fact. Using a better regex avoids extracting struct fields to begin with. Turns out that the `ArgumentDoc` class is not needed at all anymore.
avalentino
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On current
mainwhenFunctionDoc._get_arg_doc_list()extracts arguments from C doc comments it also extracts struct fields, which then have to be removed after the fact. This PR extracts arguments with a regex that avoids extracting struct fields to begin with. Turns out that theArgumentDocclass is not needed at all anymore.