Remove Argument.view_dtype property#245
Merged
avalentino merged 1 commit intoliberfa:mainfrom May 8, 2026
Merged
Conversation
eerovaher
commented
May 8, 2026
Comment on lines
-187
to
-188
| if self.ctype == 'const char': | ||
| return 'dt_bytes12' |
Contributor
Author
There was a problem hiding this comment.
Apparently self.ctype is never "const char".
In practice the property had only one possible value, so it is simpler to hardcode that value where it is used.
eerovaher
force-pushed
the
rm-Argument-view_dtype
branch
from
616a116 to
a7f4084
Compare
avalentino
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice the property has one possible value, so it is simpler to hardcode that value in the
core.pytemplate.The full difference between the files generated by
erfa_generatorin currentmainand this PR is