A few typos in the quickstart.rst#66
Merged
GuillaumeLeclerc merged 2 commits intolibffcv:mainfrom Jan 21, 2022
Merged
Conversation
A few typos corrections for the first snippet:
1) A syntax mistake {max_resolution=256, jpeg_quality=jpeg_quality} (should be either dict(max_resolution=256, jpeg_quality=jpeg_quality) or {'max_resolution': 256, 'jpeg_quality': jpeg_quality})
2) A typo in writer.from_indexed_dataset(ds) -- perhaps should be my_dataset not ds.
Collaborator
|
@andrewilyas I think the fix should be to remove the braces not using |
andrewilyas
requested changes
Jan 20, 2022
Contributor
andrewilyas
left a comment
andrewilyas
left a comment
There was a problem hiding this comment.
On line 21, I believe the dict() should be removed altogether, and the arguments passed directly to RGBImageField
Contributor
Author
|
@andrewilyas I've updated that in the last commit. |
Collaborator
|
Looks great! Thank you so much for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few typos corrections for the first snippet:
{max_resolution=256, jpeg_quality=jpeg_quality}(should be eitherdict(max_resolution=256, jpeg_quality=jpeg_quality)or{'max_resolution': 256, 'jpeg_quality': jpeg_quality})writer.from_indexed_dataset(ds)-- perhaps should bemy_datasetnotds.