Add CI images for clang with libstdc++#214
Conversation
|
🤖 Augment PR SummarySummary: This PR extends the CI image build pipeline to add Clang images that link against Changes:
Technical Notes: The workflow now selects the Docker build stage via 🤖 Was this summary useful? React with 👍 or 👎 |
| build_args: | ||
| default: null | ||
| required: false | ||
| description: Build arguments to pass to docker build, e.g. "GCC_RELEASE=16,DEBIAN_VERSION=trixie". |
There was a problem hiding this comment.
(.github/actions/build-ci-image/action.yml:22) The build_args example uses comma-separated values (e.g. GCC_RELEASE=16,DEBIAN_VERSION=trixie), but docker/build-push-action treats build-args as a newline-separated list; following the example could pass a single malformed build-arg instead of multiple.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| description: A title to include in the image metadata, e.g. "build-gcc-16". | ||
| push: | ||
| default: false | ||
| default: 'false' |
There was a problem hiding this comment.
(.github/actions/build-ci-image/action.yml:43) Composite action inputs are strings, so if: ${{ inputs.push }} will treat the literal 'false' as truthy; the "Export digest"/"Upload digest" steps may run even when pushing is disabled.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| @@ -0,0 +1 @@ | |||
| !build | |||
There was a problem hiding this comment.
(ci/.gitignore:1) Because the repo-level .gitignore ignores build/ (which matches ci/build/**), !build re-includes only the directory entry; new files under ci/build can still remain ignored unless you also re-include its contents.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| cmake --build build/ --target install ;\ | ||
| cd /work ;\ | ||
| rm -rf ${FILE} Catch2-${CATCH_RELEASE} | ||
| sh /work/build-catch.sh ;\ |
There was a problem hiding this comment.
(ci/build/clang/Dockerfile:52) build-catch.sh declares #!/bin/bash but is executed via sh, so adding any bash-specific syntax later would break the image build in a non-obvious way.
Severity: low
Other Locations
ci/build/clang/Dockerfile:70ci/build/gcc/Dockerfile:61
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.



No description provided.