add tests for error paths, option coverage, and fix existing test bugs#348
Merged
Merged
Conversation
Collaborator
abhinavagarwal07
commented
May 17, 2026
- Fix tst_open_unlink: errno assertion was dead code (inside pytest.raises block)
- Fix tst_passthrough: mnt_name pointed to src_dir, making stat comparison a no-op
- Add tst_open_writeonly_read, tst_access, tst_mkdir_exist, tst_readdir_repeated, tst_rename_sibling
- Strengthen existing tests: listdir checks on rename, truncate-to-zero, symlink cleanup, nlink after hardlink removal
- Add standalone tests for disable_hardlink, follow_symlinks, and direct_io mount options
- Compare portable stat fields in tst_passthrough (avoids st_dev/st_ino mismatch across FUSE)
h4sh5
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.