ci: add gcc/clang matrix with -Werror#353
Merged
abhinavagarwal07 merged 1 commit intoMay 21, 2026
Merged
Conversation
abhinavagarwal07
force-pushed
the
ci-werror-clang
branch
4 times, most recently
from
7041254 to
314af79
Compare
abhinavagarwal07
force-pushed
the
ci-werror-clang
branch
from
314af79 to
0d63773
Compare
h4sh5
approved these changes
May 21, 2026
- Expand build job into gcc/clang matrix with fail-fast: false - Pass -Dwerror=true so compiler warnings fail the build - Pin all actions to Node 24-capable full SHAs (checkout v6.0.2, setup-python v6.2.0, upload-artifact v7.0.1) - Add least-privilege permissions, concurrency cancellation - Pin python-version to 3.12, pin runner to ubuntu-24.04 - Add explicit SSH setup with sshd start, hard-fail FUSE preflight - Add pytest --timeout=300, --maxfail=99, JUnit XML, test result artifacts per compiler
abhinavagarwal07
force-pushed
the
ci-werror-clang
branch
from
0d63773 to
daac34f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the build job into a compiler × buildtype matrix with
fail-fast: falseso all combinations always report results.Required (4 jobs):
All pass
-Dwerror=trueto meson. Each job runs the full pytest suite.Advisory (2 jobs,
continue-on-error):-Wformat=2 -Wformat-security -Wundef -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wnull-dereference)Currently
gcc / strict warningsfails due to-Wnull-dereferenceintokenize_on_space()(sshfs.c:3965). Once that is fixed,continue-on-errorshould be removed to promote these jobs to required.Includes SHA-pinned actions, least-privilege permissions, concurrency cancellation, pinned runner and Python, SSH setup with ed25519, FUSE preflight, pytest timeouts/maxfail/JUnit XML, and per-job artifacts.