Update libgit2 to 4eb97ef #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibGit2Sharp/Core/NativeMethods.cs
Outdated
ethomson
force-pushed
the
upgradeBinaries
branch
from
8ce7371 to
fd22c0e
Compare
Member
|
I see @ethomson , didn't know! Thanks! I said I needed extra 👀 heh. |
ethomson
force-pushed
the
upgradeBinaries
branch
from
fd22c0e to
4f72ab8
Compare
Member
There was a problem hiding this comment.
Let's stop this dance. How about adding a dedicated .targets (à la Kudu)?
Member
Author
There was a problem hiding this comment.
That's clever. I'd like to address this in a separate PR, if you don't mind, but I think it's a wonderful idea.
Member
Author
|
@Therzok No problem - I went ahead and opened a new PR up because I'm being impatient. Hope you don't mind! :) |
ethomson
force-pushed
the
upgradeBinaries
branch
from
4f72ab8 to
bd75961
Compare
Member
|
Not at all, I was not here when you opened it. :D As long as it gets merged, I'm one happy person. |
Member
|
Looks great, win64 passed, linux/mac passed, |
ethomson
force-pushed
the
upgradeBinaries
branch
from
bd75961 to
8c48d39
Compare
Member
Author
|
Rebased on vnext. |
Member
|
❤️ |
Member
Author
|
👍 @Therzok - thanks a million. |
Member
|
Now we can get things rolling. I think we still need the TODO from my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgit2/libgit2@3f8d005...4eb97ef