Skip to content

Conversation

nulltoken
Copy link
Member

Attempt at being more semver compliant.

With this change AssemblyInformationalVersion will contain:

  • Local builds: 0.22.0-dev000000000000
  • Pull Request builds: 0.22.0-preDDDDDDDDDDDD
  • Merges in vNext: 0.22.0-preDDDDDDDDDDDD
  • Merges in master: 0.22.0

where

  • DDDDDDDDDDDD: UTC datetime of the build (eg. 20150231203231)

@nulltoken nulltoken added this to the v0.22 milestone Feb 3, 2015
@nulltoken nulltoken force-pushed the ntk/semver branch 4 times, most recently from c3fb967 to f0edce1 Compare February 3, 2015 19:43
@nulltoken
Copy link
Member Author

NuGet doesn't cringe anymore and correctly detect prerelease packages.

image

Provided this makes sense, the process would be, from now on:

  • vNext is merged into master -> a new stable NuGet package is generated and (manually) published
  • Add a new commit to vNext to update the version, by modifying appveyor.yaml and AssemblyInfo.cs
  • Every merged pull request will generate a new PreRelease package
  • Regularly publish those PreRelease packages

@nulltoken
Copy link
Member Author

Ready for review.

/cc @davidfowl Does this look sensible to you?

@nulltoken nulltoken mentioned this pull request Feb 3, 2015
@shiftkey
Copy link
Contributor

shiftkey commented Feb 4, 2015

@nulltoken from the semver spec:

  1. Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version.

So I think any of the pre-release builds should be of the format 0.22.0-pre+DDDDDDDDDDDD

@nulltoken
Copy link
Member Author

@shiftkey I've tried playing with the + char before but miserably failed. See this build log.

Assembly informational version was 0.22.0.0-pre20150203185935+183

But NuGet ignored it and generated a LibGit2Sharp.0.22.0.0.nupkg stable package.

It started working when I removed the offensive char. I eventually dropped the build number because of this.

@shiftkey
Copy link
Contributor

shiftkey commented Feb 4, 2015

@nulltoken oh well, guess that's the answer to the question...

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b924152 on ntk/semver into * on vNext*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants