-
Notifications
You must be signed in to change notification settings - Fork 282
Xcode 6.1 support #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 6.1 support #386
Conversation
|
So... we shouldn't merge these until the unit tests work, yes? |
|
😩 (still a work in progress) |
Unfortunately, this affects all importers of ObjectiveGit, because otherwise Clang will complain about libgit2 headers not being imported directly.
This partially reverts commit 884c069. Conflicts: Classes/GTCredential.h Classes/GTDiff.h Classes/GTDiffDelta.h Classes/GTEnumerator.h Classes/GTRepository.h
This way, we’ll look for framework-style imports within the source tree first, instead of jumping straight to the build products and potentially causing duplicate definitions.
|
Here are the build failures I'm seeing. @isaac It looks like you wrote the original iOS build scripts. Do you have any idea what might be going on? @libgit2/classy-objective-c-collaborators Have any of you used the iOS target? Would you know how to get it to build on this branch? 😕 |
|
@jspahrsummers I think I was the last one to mess with those build scripts... I can take a look. |
|
@alanjrogers ❤️ |
Fix the iOS build scripts for Xcode 6 building
We can’t actually run them because we don’t have NSTask on iOS, so we can’t unarchive the fixtures.
|
Is this ready for review? |
|
@joshvera Now it should be. Note that there are no iOS tests, because I also had to bump the iOS deployment target to 8.0 to make framework builds sane. See ReactiveCocoa/ReactiveCocoa#1413 (comment) for more context. |

The unit tests don't currently build, because Specta/Expecta haven't yet been updated for Xcode 6.