Skip to content

Conversation

@pbendersky
Copy link
Contributor

...compiling ObjectiveGit-ios (static libraries can't link to dynamic libraries).

…en compiling ObjectiveGit-ios (static libraries can't link to dynamic libraries).
pbendersky added a commit that referenced this pull request Aug 5, 2014
Removed libz from linked libraries to prevent a warning in Xcode 6 when compiling ObjectiveGit-ios (static libraries can't link to dynamic libraries).
@pbendersky pbendersky merged commit 42cd03b into libgit2:master Aug 5, 2014
@jspahrsummers
Copy link
Contributor

@pbendersky Sorry for not clarifying this beforehand, but can you wait for other collaborators to merge a pull request? We each try to avoid merging our own as well. 😄

@pbendersky
Copy link
Contributor Author

Yes, sorry :)

This applies for all the branches, correct? (I merged master back to fetch as well, without a PR).

@jspahrsummers
Copy link
Contributor

Merging master into any branch you're working on yourself is fine—just don't add commits to someone else's branch. 😉

@pbendersky
Copy link
Contributor Author

Sounds good. Thank you (and sorry again)

@jspahrsummers
Copy link
Contributor

No worries!

phatblat pushed a commit to phatblat/objective-git that referenced this pull request Sep 13, 2014
Removed libz from linked libraries to prevent a warning in Xcode 6 when compiling ObjectiveGit-ios (static libraries can't link to dynamic libraries).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants