Conversation
Member
kammce
commented
Sep 10, 2025
kammce
commented
- Support and test lpc4078
- Add benchmarks that uses empty strings (way worse than returning data)
- Support and test lpc4078 - Add benchmarks that uses empty strings (way worse than returning data)
kammce
commented
Sep 11, 2025
Member
Author
kammce
left a comment
kammce
left a comment
There was a problem hiding this comment.
Even though the performance has a regression, its required in order to give correct results.
| #include <cstdint> | ||
|
|
||
| #include <array> | ||
| #include <string> |
| 15,65,100,894.92 | ||
| 5,65,100,380.42 | ||
| 1,65,100,176.25 | ||
| 50,4,0,1303.33 |
Member
Author
There was a problem hiding this comment.
This requires the search_EIT_Table function to be give public visibility and have its symbol weakened.
kammce
force-pushed
the
string-benchmark
branch
from
06353da to
718fbfd
Compare
kammce
force-pushed
the
string-benchmark
branch
from
718fbfd to
c63ac36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.