Conversation
|
currently, the reset command is declared as a private method but is unimplemented. Should it be removed? or is it better to leave it there for the binary interface consistency (I'm not sure how ABIs work) |
kammce
left a comment
There was a problem hiding this comment.
Great work! Much of my comments have to do with formatting and documentation. The rest mostly looks good.
See my comment on what you should do about reset. As for ABI, class functions do not effect the ABI of a function so nothing to worry about from that angle. |
17d27e1 to
77b7fc7
Compare
|
I can perform a other review once CI has passed. I recently re-enabled clang-tidy static analysis which is why there are so many new errors popping up. |
kammce
left a comment
There was a problem hiding this comment.
Looks good! One last little fix in the form of a C style cast and we can submit this.
Co-authored-by: Khalil Estell <kammcecorp@gmail.com>
The tla2528 is an i2c-based GPIO expander and ADC mux. It has 8 pins that can each be independently configured and operated as GPIO or ADC. This is a port of the tla2528 driver and adapters from the SJSU robotics team.
Features
Missing/future/unimplemented features: