Merged
Conversation
Contributor
Author
|
@kammce Ready for draft review |
Member
|
Can you change this from a draft to a PR and make sure that CI is passing. Then I'll review. |
kammce
requested changes
Oct 24, 2024
Member
kammce
left a comment
kammce
left a comment
There was a problem hiding this comment.
Great job Xander! This looks great!
- Brokeout the temperature and pressure calculations into functions. - Added unit tests for the calculation functions using the datasheet sample data. - Updated helper function to wait for conversion. - Updated/fixed comments and added more clarifying information. - Some additional tidying-up and minor edits
kammce
requested changes
Oct 29, 2024
Member
kammce
left a comment
kammce
left a comment
There was a problem hiding this comment.
Great work on the tests! Just a few last things, and we can merge this in.
kammce
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.