Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

✨ Add support for i2c bit bang#7

Merged
kammce merged 4 commits intolibhal:mainfrom
Coreyboy1820:i2c_bit_bang
Mar 19, 2024
Merged

✨ Add support for i2c bit bang#7
kammce merged 4 commits intolibhal:mainfrom
Coreyboy1820:i2c_bit_bang

Conversation

@Coreyboy1820
Copy link
Copy Markdown

@Coreyboy1820 Coreyboy1820 commented Mar 17, 2024

  • Add support for read and write operations
  • Add support for speeds up to about 200kHz
  • Add captures of working bit-bang with uncalibrated and calibrated frequencies

@Coreyboy1820 Coreyboy1820 force-pushed the i2c_bit_bang branch 2 times, most recently from 39d4834 to 8ccc984 Compare March 17, 2024 04:07
@Coreyboy1820 Coreyboy1820 changed the title ✨ add support for i2c bit bang ✨ Add support for i2c bit bang Mar 17, 2024
@Coreyboy1820 Coreyboy1820 changed the title ✨ Add support for i2c bit bang ✨ Add support for i2c bit bang Mar 17, 2024
@Coreyboy1820 Coreyboy1820 force-pushed the i2c_bit_bang branch 4 times, most recently from e4ae060 to 051578b Compare March 17, 2024 07:59
- implements read and write operations
- supports speeds up to about 200kHz
@Coreyboy1820
Copy link
Copy Markdown
Author

@kammce ready for review.

Comment thread demos/platforms/lpc4074.cpp
Comment thread include/libhal-soft/i2c_bit_bang.hpp Outdated
Comment thread include/libhal-soft/i2c_bit_bang.hpp Outdated
Comment thread include/libhal-soft/i2c_bit_bang.hpp Outdated
Comment thread include/libhal-soft/i2c_bit_bang.hpp Outdated
Comment thread src/i2c_bit_bang.cpp Outdated
Comment thread src/i2c_bit_bang.cpp Outdated
Comment thread src/i2c_bit_bang.cpp Outdated
Comment thread src/i2c_bit_bang.cpp Outdated
Comment thread src/i2c_bit_bang.cpp Outdated
Co-authored-by: Khalil Estell <kammcecorp@gmail.com>
@Coreyboy1820
Copy link
Copy Markdown
Author

New capture has been uploaded as well.

Copy link
Copy Markdown
Member

@kammce kammce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Most of my additional feedback is for comments. So once we get that fixed and resolved we can merge this.

Comment thread include/libhal-soft/bit_bang_i2c.hpp Outdated
Comment thread include/libhal-soft/bit_bang_i2c.hpp Outdated
Comment thread include/libhal-soft/bit_bang_i2c.hpp Outdated
Comment thread include/libhal-soft/bit_bang_i2c.hpp Outdated
Comment thread include/libhal-soft/bit_bang_i2c.hpp Outdated
Comment thread src/bit_bang_i2c.cpp Outdated
Comment thread include/libhal-soft/bit_bang_i2c.hpp Outdated
@Coreyboy1820 Coreyboy1820 force-pushed the i2c_bit_bang branch 3 times, most recently from fbeaccf to 3668df1 Compare March 18, 2024 23:21
@Coreyboy1820
Copy link
Copy Markdown
Author

Added both un-calibrated and calibrated seleae captures for proof of negligible improvements.

@kammce
Copy link
Copy Markdown
Member

kammce commented Mar 19, 2024

LGTM. Merging.

@kammce kammce merged commit 9a547cd into libhal:main Mar 19, 2024
@Coreyboy1820 Coreyboy1820 deleted the i2c_bit_bang branch March 19, 2024 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants