Skip to content

🐛 Set correct constexpr/consteval for bit_mask #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kammce merged 1 commit into from
Oct 12, 2024
Merged

🐛 Set correct constexpr/consteval for bit_mask #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions include/libhal-util/bit.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ struct bit_mask
* position1 and position2 can be in any order so long as they span the
* distance from the start and end of the bit_mask range.
*
* Use this when you REQUIRE the bit mask to be generated at compile time,
* because template arguments are required to be known at compile time.
*
* @tparam position1 - bit position 1
* @tparam position2 - bit position 2
* @return consteval bit_mask - bit bit_mask represented by the two bit
Expand All @@ -70,12 +73,15 @@ struct bit_mask
* @ingroup Bit
* @brief Generate, at compile time, a single bit width bit_mask at position
*
* Use this when you REQUIRE the bit mask to be generated at compile time,
* because template arguments are required to be known at compile time.
*
* @tparam position - the bit to make the bit_mask for
* @return constexpr bit_mask - bit bit_mask with the position bit set to
* position
*/
template<std::uint32_t position>
static constexpr bit_mask from()
static consteval bit_mask from()
{
return bit_mask{ .position = position, .width = 1U };
}
Expand All @@ -96,7 +102,7 @@ struct bit_mask
* @return consteval bit_mask - bit bit_mask represented by the two bit
* positions
*/
static consteval bit_mask from(std::uint32_t position1,
static constexpr bit_mask from(std::uint32_t position1,
std::uint32_t position2)
{
constexpr std::uint32_t plus_one = 1;
Expand Down