🐛 Fix protocol & timing issues w/ bit_bang_i2c#54
Merged
Conversation
kammce
force-pushed
the
fix-bit-bang-i2c
branch
from
6c18e8b to
81f7d68
Compare
The state of the output pins provided to `hal::bit_bang_i2c` can be in any state, meaning that the i2c bus may be in a state that will not work initially. In order to initialize the bus to a known state, `hal::probe(*this, 0x00)` is called twice.
kammce
force-pushed
the
fix-bit-bang-i2c
branch
from
81f7d68 to
55de2be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state of the output pins provided to
hal::bit_bang_i2ccan be inany state, meaning that the i2c bus may be in a state that will not work
initially. In order to initialize the bus to a known state,
hal::probe(*this, 0x00)is called twice.