🔥 Remove require_cmake and require_ninja options from llvm-toolc… #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move cmake and ninja from conanfile.py tool_requires to profile-level dependencies to avoid transitive dependency propagation issues. Changes: - Remove require_cmake and require_ninja options from conanfile.py - Remove build_requirements() method entirely - Simplify package_info() to unconditionally enable C++ modules support - Update package_id() to remove deleted option references - Update README.md to document cmake/ninja as profile requirements - Add example profile showing cmake, ninja, and Ninja generator config Benefits: - Eliminates transitive dependency conflicts with visible=True - Provides better separation of concerns (toolchain vs build tools) - Gives users full control over cmake/ninja versions via profiles - Follows Conan 2.x best practices for tool requirements - Maintains C++20 modules support without conditional logic Breaking change: Users must now include cmake and ninja in their profiles if needed. All provided profiles have been updated accordingly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move cmake and ninja from conanfile.py tool_requires to profile-level dependencies to avoid transitive dependency propagation issues.
Changes:
Benefits:
Breaking change: Users must now include cmake and ninja in their profiles if needed. All provided profiles have been updated accordingly.
🤖 Generated with Claude Code