Adapt CMake scripts for WebAssembly compilation#344
Merged
bramton merged 2 commits intolibharu:masterfrom Jul 9, 2025
Merged
Conversation
This script doesn't seem to be used as the MATH_LIB variable is never used elsewhere and there's another `find_library` call for the math library in the root `CMakeLists.txt`. Plus, this script incorrectly errors out in case of a compilation for WebAssembly.
Don't try to link the Math library when compiling with emscripten, as it's already provided by the system (Compiler throws warnings for missing linked libraries unless compiling to JS emscripten-core/emscripten#2600). Also added some additional details to CMake summary related with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the library with emscripten for WebAssembly, the only issue is that the current CMake script requires the math library, which is already provided by the system.