Support additional image types#22
Merged
tylerfanelli merged 2 commits intoJan 17, 2025
Merged
Conversation
Collaborator
Author
|
Keeping this a draft for the time being since libkrun doesn't have a release cut with the Qcow2 commits |
tylerfanelli
requested changes
Dec 18, 2024
Collaborator
|
I think you can squash commits so there are just two. One for the implementation, and one for the documentation. |
jakecorrenti
force-pushed
the
support-additional-image-types
branch
from
a08fa27 to
9e1ffbb
Compare
Link with libkrun's new `krun_add_disk2` API to allow the user to use either a Raw or Qcow2 disk image. Adds the `format` argument to the `virtio-blk` device. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates the virtio-blk documentation to specify the new `format` arugment. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
jakecorrenti
force-pushed
the
support-additional-image-types
branch
from
9e1ffbb to
3d1ded1
Compare
tylerfanelli
approved these changes
Dec 18, 2024
Collaborator
tylerfanelli
left a comment
tylerfanelli
left a comment
There was a problem hiding this comment.
LGTM. We'll wait for the libkrun release.
Collaborator
Author
|
libkrun 1.10 got released, so marking this as ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the command line to support the new
krun_add_disk2API in libkrun. This will allow the user to specify non-Raw disk image formats. The list of supported disk image formats is now: Raw, Qcow2.