Re-write argument parsing#39
Merged
Merged
Conversation
Adds `parse_args`, `check_required_args`, and `check_unknown_args`. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates the argument parsing for `virtio-blk` to use new helper functions. Makes the `format=` argument optional and provides the default value `raw`. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates virtio-net argument parsing to use new helper functions. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates virtio-serial argument parsing to use the new helper functions Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates virtio-vsock argument parsing to use the new helper functions Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates virtio-fs argument parsing to use the new helper functions Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates virtio-input to use the new helper functions Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates virtio-gpu to use the new helper functions Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Updates the argument parsing in src/cmdline.rs to no longer use `args_parse` or `val_parse`. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Collaborator
Author
|
@tylerfanelli PTAL |
tylerfanelli
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous method for parsing the command-line arguments required the device arguments, for example, to be in a hard-coded order, and they were all considered required. Additionally, if a specific argument was missing, or there were extra arguments, the error messages could be somewhat vague.
These changes allow for more granular error message, optional arguments that have a default value, and for the user to put the arguments in any particular order.
Closes: #30