Add a cmdline flag to request nested virt#40
Merged
Conversation
Version 1.11 of libkrun introduces support for Nested Virtualization on macOS hosts. Let's add a flag to allow users to request its enablement. Signed-off-by: Sergio Lopez <slp@redhat.com>
Collaborator
Author
|
Creating this one as a draft since it requires a new release of libkrun. |
Collaborator
Author
|
With libkrun-1.11.0 out, we can mark this one as ready to review. |
jakecorrenti
approved these changes
Apr 7, 2025
Collaborator
jakecorrenti
left a comment
jakecorrenti
left a comment
There was a problem hiding this comment.
LGTM. Verified on my M1 that enabling nested will fail and the option isn't required.
Collaborator
|
@tylerfanelli did you ever figure out how to shut off the verified signatures requirement on PRs? |
Collaborator
Author
|
@jakecorrenti I've just disabled the requirement. |
Collaborator
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.11 of libkrun introduces support for Nested Virtualization on macOS hosts. Let's add a flag to allow users to request its enablement.