cmdline: context: add --pidfile option#71
Conversation
72d73c2 to
3a7e4ab
Compare
|
I wonder if this may work better as a PR in libkrun first, which we can then expose here in krunkit after. There's a possible scenario where you create the pidfile, something fails in |
This is very unlikely and the window is small. I think creating it before starting is good enough and it matches what vfkit does. Programs running krunkit should check if the process terminated when they wait until the vm is reachable. I already do this in vment-helper test script, implementing this in minikube is easy. |
Add a new --pidfile option. This will allow the user to specify a path in which the krunkit binary will write its PID. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
3a7e4ab to
c47f8d7
Compare
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
40d0687 to
237dd7b
Compare
Add a new --pidfile option. This will allow the user to specify a path in which the krunkit binary will write its PID.
Resolves: #42