context: check if restful URI scheme is None#77
Merged
Conversation
Before starting the status listener thread, we not only need to check if the RestfulUri variant != None, but we also need to verify the user specified a restful URI scheme at all. This prevents a panic when we call `status_listener()` due to hitting an `unreachable!()` code path. Functionally, the panic didn't affect users; it's difficult to catch since the VM starts immediately after the message is printed to stdout. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
tylerfanelli
approved these changes
Sep 25, 2025
Collaborator
tylerfanelli
left a comment
tylerfanelli
left a comment
There was a problem hiding this comment.
LGTM, but where is this unreachable!() you mention?
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before starting the status listener thread, we not only need to check if the RestfulUri variant != None, but we also need to verify the user specified a restful URI scheme at all.
This prevents a panic when we call
status_listener()due to hitting anunreachable!()code path. Functionally, the panic didn't affect users; it's difficult to catch since the VM starts immediately after the message is printed to stdout.