Allow reading Cmd and WorkingDir from the OCI image config#18
Merged
Conversation
libkrun's init is now able to read the workload parameters from a
per-container configuration file ("/krun_config.json"). Since the
configuration set via the library takes preference over the settings
in the configuration file, avoid configuring a initial binary nor a
workdir unless the user has explicitly requested them.
In case the configuration file is missing, libkrun's init is able to
fall back to some reasonable defaults.
Signed-off-by: Sergio Lopez <slp@redhat.com>
libkrun's init/init.c is now able to read the workload parameters from
an OCI config file. Use "buildah inspect" to obtain this configuration
and write it to the expected location ("/.krun_config.json").
Signed-off-by: Sergio Lopez <slp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.