Resolve clippy warnings and use correct types in bindings#47
Merged
Conversation
Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
resolve-warnings
branch
from
055ba29 to
4d58b65
Compare
bindings were using i8 instead of c_char for C string pointers, but the types are defined as c_char in libkrun. There were a lot of unecessary casts from i8 to c_char according to clippy because on x86_64 they are the same type. (The casts were necessary on ARM, because c_char is unsigned on ARM). Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
resolve-warnings
branch
from
4d58b65 to
acf6f43
Compare
Collaborator
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bindings were using i8 instead of c_char for C string pointers, but the types are defined as c_char in libkrun.
There were a lot of unnecessary casts from i8 to c_char according to clippy because on x86_64 they are the same type.
(The casts were necessary on ARM, because c_char is unsigned on ARM).