Skip to content

Fix aarch64 i8/u8 mismatch and improve pipeline#55

Merged
slp merged 4 commits into
libkrun:mainfrom
mtjhrc:fix-aarch64
Nov 29, 2023
Merged

Fix aarch64 i8/u8 mismatch and improve pipeline#55
slp merged 4 commits into
libkrun:mainfrom
mtjhrc:fix-aarch64

Conversation

@mtjhrc
Copy link
Copy Markdown
Collaborator

@mtjhrc mtjhrc commented Nov 2, 2023

Fixes #53

@mtjhrc mtjhrc force-pushed the fix-aarch64 branch 2 times, most recently from d465f0d to 78b1dcf Compare November 2, 2023 10:30
Signed-off-by: Matej Hrica <mhrica@redhat.com>
This seems to catch more problems, such as the u8/i8 mismatch on
aarch64 platforms.

Signed-off-by: Matej Hrica <mhrica@redhat.com>
We need #[allow(unused_mut)], to disable warnings on other targets.

Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
@mtjhrc mtjhrc marked this pull request as ready for review November 2, 2023 11:47
@mtjhrc mtjhrc requested a review from slp November 2, 2023 18:36
Copy link
Copy Markdown
Collaborator

@slp slp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging this one instead of #54. The new checks in the pipeline are a nice addition too.

@slp slp merged commit 27a6dfb into libkrun:main Nov 29, 2023
@slp slp mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"mismatched types" error while building

2 participants