Skip to content

Pass environment variable(s) to microVM#58

Merged
slp merged 2 commits into
libkrun:mainfrom
EduM22:feat/set-env
Jun 10, 2024
Merged

Pass environment variable(s) to microVM#58
slp merged 2 commits into
libkrun:mainfrom
EduM22:feat/set-env

Conversation

@EduM22
Copy link
Copy Markdown
Contributor

@EduM22 EduM22 commented Feb 4, 2024

Added the ability to pass environment variable(s) to the microVM when starting it.

Signed-off-by: EduM22 <38257387+EduM22@users.noreply.github.com>
@slp
Copy link
Copy Markdown
Collaborator

slp commented Feb 6, 2024

Thanks for your contribution. Could you please remove the third empty commit?

Signed-off-by: EduM22 <38257387+EduM22@users.noreply.github.com>
@EduM22
Copy link
Copy Markdown
Contributor Author

EduM22 commented Feb 6, 2024

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

@ericcurtin
Copy link
Copy Markdown

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

git rebase -i HEAD~3

is a useful tool if you want to change one of the last three commits. Or "drop" one in this case.

Although if the empty commit was at the HEAD, it's simpler to do:

git reset --hard HEAD~

and then a:

git push -f

people create new PRs sometimes to redo things, which is ok, but it's something you rarely have to do.

@EduM22
Copy link
Copy Markdown
Contributor Author

EduM22 commented Feb 12, 2024

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

git rebase -i HEAD~3

is a useful tool if you want to change one of the last three commits. Or "drop" one in this case.

Although if the empty commit was at the HEAD, it's simpler to do:

git reset --hard HEAD~

and then a:

git push -f

people create new PRs sometimes to redo things, which is ok, but it's something you rarely have to do.

Thanks for the help.

@slp is it up to spec now?

@h7io
Copy link
Copy Markdown

h7io commented Jun 9, 2024

Hey guys,

anything holding this up?

@slp
Copy link
Copy Markdown
Collaborator

slp commented Jun 10, 2024

Sorry, I lost track of this one. LGTM, merging it.

@slp slp merged commit 765614c into libkrun:main Jun 10, 2024
@EduM22 EduM22 deleted the feat/set-env branch June 10, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants