config: enable EROFS xattr and security support on x86_64#119
Merged
Conversation
appcypher
requested review from
MatiasVara,
slp and
tylerfanelli
as code owners
|
@appcypher not a maintainer but you need to sign your commit or it won't even be considered. |
Contributor
Author
|
it is signed. |
Contributor
|
It will show an extra line at the bottom reading |
Add CONFIG_EROFS_FS_XATTR and CONFIG_EROFS_FS_SECURITY to the x86_64 kernel config, aligning it with aarch64 and riscv64 which already have these enabled. Required for trusted.overlay.opaque xattr (used by overlayfs for opaque directory markers) and security.* xattrs on EROFS filesystems. Signed-off-by: Stephen Akinyemi <appcypher@outlook.com>
appcypher
force-pushed
the
appcypher/enable-erofs-xattr-x86_64
branch
from
1354e32 to
25dc715
Compare
hsiangkao
approved these changes
Apr 20, 2026
hsiangkao
approved these changes
Apr 20, 2026
hsiangkao
left a comment
hsiangkao
left a comment
There was a problem hiding this comment.
Won't libkrunfw enable "default y" configurations? if not, it makes sense to me.
Collaborator
|
LGTM, thanks! |
slp
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I noticed that the x86_64 kernel config is missing
CONFIG_EROFS_FS_XATTRandCONFIG_EROFS_FS_SECURITY, even though both aarch64 and riscv64 already have them enabled.This means EROFS on x86_64 can't handle extended attributes, specifically
trusted.overlay.*xattrs that overlayfs uses for opaque directory markers, andsecurity.*xattrs.This came up while working on a project that uses EROFS as the rootfs backing for VM-based containers.
The fix is just adding the two missing config lines to
config-libkrunfw_x86_64to match what the other architectures already have.