add TDX support#92
Merged
Merged
Conversation
Collaborator
|
We should have two qboot binaries, one for SNP and another for TDX, choosing the right one in Makefile. |
Collaborator
|
So far LGTM. Not merging since it's still a draft. |
jakecorrenti
requested review from
MatiasVara,
slp and
tylerfanelli
as code owners
Contributor
Author
|
This is ready to go, I just haven't been able to verify everything still works for SNP since I don't have a machine |
tylerfanelli
requested changes
Apr 21, 2025
Adds support for a TDX flavor. Additionally adjusts the qboot binary locations such that SEV has a different binary than TDX. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Collaborator
tylerfanelli
left a comment
tylerfanelli
left a comment
There was a problem hiding this comment.
Changes LGTM. I just want to test with SEV-SNP before giving sign-off approval.
tylerfanelli
approved these changes
May 2, 2025
Collaborator
tylerfanelli
left a comment
tylerfanelli
left a comment
There was a problem hiding this comment.
Tested on SEV-SNP. LGTM!
Contributor
Author
|
@slp is this good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.