Merged
Conversation
ATechAdventurer
approved these changes
Sep 8, 2025
skosijer
commented
Sep 9, 2025
| } else { | ||
| // In production, this should fail - never generate a key | ||
| if (env.server.NODE_ENV === 'production') { | ||
| if (process.env.NODE_ENV === 'production') { |
Contributor
Author
There was a problem hiding this comment.
Managed to solve this bug through this PR.
Contributor
Author
There was a problem hiding this comment.
Explanation of the issue:
The whole data-access/ folder ends in the built app starters (next-starter, remix-starter).
This is how the code sharing is being possible between the liblab ai builder and the built app starters.
For that reason we cannot use any imports relative to the ai builder (e.g. "~/env") because the folder copying logic will try to define the built app package.json and it will assume from this line that there is a dependency for "~": "latest" which will eventually break the built app installation and preview because of a missing module error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Pull Request Summary