Merged
Conversation
Resolved conflict in EnvironmentsTab.tsx by keeping the cleaner dev version structure. Fixed lint error in next-env.d.ts by replacing triple slash reference with import.
Merges API integration POC branch with breaking changes for data access architecture refactoring. Resolves conflicts by adapting current branch changes to new property-based data source configuration.
kapicic
reviewed
Sep 11, 2025
| headers: { | ||
| 'Content-Type': 'application/x-www-form-urlencoded', | ||
| }, | ||
| body: new URLSearchParams({ |
Contributor
There was a problem hiding this comment.
why are we using URLSearchParams in the request body?
Contributor
Author
There was a problem hiding this comment.
@kapicic The URLSearchParams usage is correct here. Google's OAuth2 token exchange endpoint requires application/x-www-form-urlencoded format, and URLSearchParams is the standard JavaScript way to create this format. This follows the OAuth2 specification requirements for token exchange requests.
kapicic
reviewed
Sep 11, 2025
kapicic
reviewed
Sep 11, 2025
kapicic
reviewed
Sep 11, 2025
kapicic
reviewed
Sep 11, 2025
kapicic
reviewed
Sep 11, 2025
Contributor
|
Hey please take another look @kapicic so we can close this one as well 👍🏻 |
kapicic
approved these changes
Sep 12, 2025
Contributor
kapicic
left a comment
kapicic
left a comment
There was a problem hiding this comment.
Small nit about using array(any()) but lgtm otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Pull Request Summary
Updated Google Sheet data connector UI with redesign.