-
Notifications
You must be signed in to change notification settings - Fork 13
Add Role Management UI #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a42bba1
extend getRoles to include users
bears4barrett 73be881
add roles tab to control panel
bears4barrett f07defa
add reusable control panel header with back functionality
bears4barrett 4f5f59c
added support for update role name and description
bears4barrett 82f5ebb
add radix toggle group
bears4barrett 4675153
add initial role users to role details
bears4barrett 580cc55
fix handle of tab click on same tab
bears4barrett f4ccc47
fix scrolling in role details
bears4barrett 0381654
added assign role members
bears4barrett ede34c0
added delete role
bears4barrett 9b1ead5
do not refresh roles on delete
bears4barrett ce15f64
corrected react key placement
bears4barrett 719a871
feedback fixes
bears4barrett 4928ea4
improved members not in role efficiency
bears4barrett e090b5a
fix label
bears4barrett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import React from 'react'; | ||
| import { useStore } from '@nanostores/react'; | ||
| import { classNames } from '~/utils/classNames'; | ||
| import { ArrowLeft } from 'lucide-react'; | ||
| import { CloseCircle } from 'iconsax-reactjs'; | ||
| import { closeSettingsPanel, settingsPanelStore } from '~/lib/stores/settings'; | ||
|
|
||
| export const ControlPanelHeader = () => { | ||
| const { header } = useStore(settingsPanelStore); | ||
|
|
||
| return ( | ||
| <div | ||
| className={classNames( | ||
| 'flex items-center justify-between h-16 px-6 bg-gray-50 dark:bg-gray-900 flex-shrink-0', | ||
| header.onBack || header.title ? 'border-b border-gray-700/50' : '', | ||
| )} | ||
| > | ||
| <div className="flex-1 min-w-0"> | ||
| <div className="flex items-center gap-2"> | ||
| {header.onBack && ( | ||
| <button | ||
| onClick={header.onBack} | ||
| className="p-1 rounded-full hover:bg-gray-200 dark:hover:bg-gray-700 cursor-pointer transition-colors" | ||
| aria-label="Go back" | ||
| > | ||
| <ArrowLeft className="w-5 h-5" /> | ||
| </button> | ||
| )} | ||
| {header.title && ( | ||
| <h2 className="text-base font-semibold text-gray-900 dark:text-white truncate">{header.title}</h2> | ||
| )} | ||
| </div> | ||
| </div> | ||
| <div className="pl-4"> | ||
| <CloseCircle | ||
| variant="Bold" | ||
| className="w-6 h-6 text-gray-500 dark:text-white hover:text-gray-700 dark:hover:text-gray-400 transition-colors cursor-pointer" | ||
| onClick={closeSettingsPanel} | ||
| /> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
181 changes: 181 additions & 0 deletions
181
app/components/@settings/tabs/roles/AssignRoleMembers.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,181 @@ | ||
| import { useState, useEffect, useMemo } from 'react'; | ||
| import { setControlPanelHeader } from '~/lib/stores/settings'; | ||
| import { Circle, CircleCheck, Search } from 'lucide-react'; | ||
| import { toast } from 'sonner'; | ||
| import type { Role, User } from './types'; | ||
|
|
||
| type AssignRoleMembersProps = { | ||
| role: Role; | ||
| onRoleUpdate: (updatedRole: Role) => void; | ||
| closeAssignMembers: () => void; | ||
| }; | ||
|
|
||
| export default function AssignRoleMembers({ role, onRoleUpdate, closeAssignMembers }: AssignRoleMembersProps) { | ||
| const [searchQuery, setSearchQuery] = useState(''); | ||
| const [membersNotInRole, setMembersNotInRole] = useState<User[]>([]); | ||
| const [selectedUsers, setSelectedUsers] = useState<Map<string, User>>(new Map()); | ||
| const [isLoading, setIsLoading] = useState(false); | ||
| const [isSaving, setIsSaving] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| setControlPanelHeader({ | ||
| title: `Assign members to "${role.name}" role`, | ||
| onBack: closeAssignMembers, | ||
| }); | ||
|
|
||
| const fetchMembersNotInRole = async () => { | ||
| try { | ||
| setIsLoading(true); | ||
|
|
||
| const response = await fetch('/api/organization/member'); | ||
| const data: { members: User[] } = await response.json(); | ||
|
|
||
| if (data.members) { | ||
| const roleUserIds = new Set(role.users?.map((user) => user.id)); | ||
| const membersNotInRoleList: User[] = data.members | ||
| .filter((member) => !roleUserIds.has(member.id)) | ||
| .map((member) => ({ id: member.id, name: member.name, email: member.email })); | ||
|
|
||
| setMembersNotInRole(membersNotInRoleList); | ||
| } | ||
| } catch (error) { | ||
| console.error('Error fetching organization members:', error); | ||
| toast.error('Failed to fetch organization members'); | ||
| } finally { | ||
| setIsLoading(false); | ||
| } | ||
| }; | ||
|
|
||
| fetchMembersNotInRole(); | ||
| }, []); | ||
|
bears4barrett marked this conversation as resolved.
|
||
|
|
||
| const handleAssignMembers = async () => { | ||
| if (selectedUsers.size === 0) { | ||
| return; | ||
| } | ||
|
|
||
| setIsSaving(true); | ||
|
|
||
| const newRoleUsers = new Map(selectedUsers); | ||
|
|
||
| try { | ||
| await Promise.all( | ||
| Array.from(selectedUsers.values()).map((user) => | ||
| fetch(`/api/roles/${role.id}/users`, { | ||
| method: 'POST', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ userId: user.id }), | ||
| }).then((res) => { | ||
| if (!res.ok) { | ||
| const failedUser = membersNotInRole.find((m) => m.id === user.id); | ||
| toast.error(`Failed to assign member "${failedUser?.email || 'Unknown'}"`); | ||
| newRoleUsers.delete(user.id); | ||
| } | ||
| }), | ||
| ), | ||
| ); | ||
|
|
||
| const updatedRole = { | ||
| ...role, | ||
| users: [...(role.users || []), ...Array.from(newRoleUsers.values())], | ||
| }; | ||
| onRoleUpdate(updatedRole); | ||
| closeAssignMembers(); | ||
| } finally { | ||
| setIsSaving(false); | ||
| } | ||
| }; | ||
|
|
||
| const toggleSelectUser = (user: User) => { | ||
| if (!user?.id) { | ||
| return; | ||
| } | ||
|
|
||
| setSelectedUsers((prev) => { | ||
| const newSelected = new Map(prev); | ||
|
|
||
| if (newSelected.has(user.id)) { | ||
| newSelected.delete(user.id); | ||
| } else { | ||
| newSelected.set(user.id, user); | ||
| } | ||
|
|
||
| return newSelected; | ||
| }); | ||
| }; | ||
|
|
||
| const filteredMembers = useMemo( | ||
| () => | ||
| membersNotInRole.filter( | ||
| (member) => | ||
| member.name.toLowerCase().includes(searchQuery.toLowerCase()) || | ||
| member.email.toLowerCase().includes(searchQuery.toLowerCase()), | ||
| ), | ||
| [membersNotInRole, searchQuery], | ||
| ); | ||
|
|
||
| if (isLoading) { | ||
| return ( | ||
| <div className="flex items-center justify-center p-8"> | ||
| <div className="text-gray-400">Loading members...</div> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <div> | ||
| <div className="relative flex-1 mb-3"> | ||
| <div className="absolute left-2 top-1/2 -translate-y-1/2 flex items-center pointer-events-none"> | ||
| <Search className="w-4 h-4 text-gray-400" /> | ||
| </div> | ||
| <input | ||
| type="text" | ||
| value={searchQuery} | ||
| onChange={(e) => setSearchQuery(e.target.value)} | ||
| className="w-full h-9 pl-7 pr-2.5 py-2 rounded-[50px] bg-gray-600/50 text-sm text-white placeholder-gray-400 focus:outline-none" | ||
| placeholder="Search members..." | ||
| /> | ||
| </div> | ||
|
|
||
| <div className="text-sm text-gray-400 px-4 py-2 border-b border-gray-700">Assign members</div> | ||
|
|
||
| <div className="min-h-106"> | ||
| {filteredMembers.map((member) => ( | ||
| <div | ||
| key={member.id} | ||
| className="flex items-center gap-6 p-4 border-b border-gray-700/50 cursor-pointer" | ||
| onClick={() => toggleSelectUser(member)} | ||
| > | ||
| {selectedUsers.has(member.id) ? ( | ||
| <CircleCheck className="w-5 h-5 text-accent-500" /> | ||
| ) : ( | ||
| <Circle className="w-5 h-5 text-gray-600 dark:text-gray-400" /> | ||
| )} | ||
| <div className="space-y-1"> | ||
| <div className="text-sm text-white">{member.name}</div> | ||
| <div className="text-sm text-gray-400">{member.email}</div> | ||
| </div> | ||
| </div> | ||
| ))} | ||
|
|
||
| {filteredMembers.length === 0 && !isLoading && ( | ||
| <div className="p-4 text-sm text-gray-400">No members found</div> | ||
| )} | ||
| </div> | ||
|
|
||
| <div className="sticky bottom-0 left-0 right-0 -m-6 border-t border-gray-800 bg-gray-50 dark:bg-gray-900"> | ||
| <div className="flex justify-end p-4"> | ||
| <button | ||
| onClick={handleAssignMembers} | ||
| disabled={isSaving || selectedUsers.size === 0} | ||
| className="px-4 py-2 bg-accent-500 hover:bg-accent-600 text-gray-950 dark:text-gray-950 rounded-lg transition-colors text-sm font-medium disabled:opacity-50 disabled:cursor-not-allowed" | ||
| > | ||
| {isSaving | ||
| ? 'Assigning Members...' | ||
| : `Assign ${selectedUsers.size ? selectedUsers.size : ''} Member${selectedUsers.size !== 1 ? 's' : ''}`} | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a reason why we're doing this? To add more emphasis and to prevent somebody from deleting this line without reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add in the next PR.