Truncate column examples to save on session space#3
Open
zerocrates wants to merge 1 commit intolibmanuk:masterfrom
Open
Truncate column examples to save on session space#3zerocrates wants to merge 1 commit intolibmanuk:masterfrom
zerocrates wants to merge 1 commit intolibmanuk:masterfrom
Conversation
The plugin has historically told users to alter the Omeka session table definition to allow more storage. This is only necessary because the plugin stores the entire content of each "column" in the session before showing the mapping page. Only the first few characters are ever visible, so we can just truncate the column example texts before returning them and the length of the transcript will no longer matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin has historically told users to alter the Omeka session table definition to allow more storage. This is only necessary because the plugin stores the entire content of each "column" in the session before showing the mapping page. Only the first few characters are ever visible, so we can just truncate the column example texts before returning them and the length of the transcript will no longer matter.