Vs2017 dev#2
Merged
malloch merged 2 commits intolibmapper:mainfrom May 13, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C90 compatible changes for mpr.in/out (variable length arrays changed to malloc / free)
CLASS_ATTR_LONG changed to CLASS_ATTR_ATOM_LONG for instance_id since in Win64 a long is only 4 bytes (may need further verification this change doesn't have any unintentional consequences).
Some #ifdefs for Windows-specific settings, including addition of ext_main function which appears to be necessary for Windows.
Briefly tested and it seems to compile and run fine in OSX with these changes.
Compiled test package available here