Skip to content

[WIP] Refactor the Display struct in display.h to use the PIMPL idiom pattern similar to window.h, converting it from a struct to a class with private implementation details hidden behind a forward-declared Impl class and pimpl_ pointer.#23

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/fix-496058e9-5913-4845-9202-9707351e0cdf

Conversation

Copy link
Contributor

Copilot AI commented Sep 21, 2025

  • Analyze the current Display struct implementation in display.h
  • Examine how Window class uses the PIMPL idiom as a reference
  • Identify all files that use the Display struct
  • Build and verify current codebase works
  • Create Display.cpp implementation file with PIMPL pattern
  • Refactor display.h to convert struct to class with private implementation
  • Update platform-specific display_manager implementations to work with new Display class
  • Update C API to work with new Display class
  • Update display events to work with new Display class
  • Build and test changes
  • Verify all examples and tests still work

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants