fix(windows): implement SetMinimumSize/SetMaximumSize via WM_GETMINMAXINFO#44
Merged
Conversation
…XINFO The SetMinimumSize and SetMaximumSize methods on Windows were empty placeholder implementations that did nothing. This caused setting window size constraints to have no effect in Flutter apps and other consumers. Fix by: - Storing min/max size constraints in Window::Impl - Registering a WM_GETMINMAXINFO handler via WindowMessageDispatcher that reads the constraints from the Window object and sets ptMinTrackSize/ptMaxTrackSize on the MINMAXINFO structure - This works for both self-created windows and Flutter-hosted windows (via Window(void*) constructor) - Triggering SWP_FRAMECHANGED after setting constraints so the window immediately re-evaluates them - Properly cleaning up the handler in the destructor Closes libnativeapi/nativeapi-flutter#9
Use per-monitor DPI scaling across Windows platform code: apply GetScaleFactorForMonitor/Window to convert between physical pixels and logical coordinates for displays, cursor, and window geometry. Updated DisplayManager::GetCursorPosition, Display::GetPosition/GetSize/GetWorkArea/GetScaleFactor, and many Window methods (SetBounds/GetBounds/SetSize/GetSize/SetContentSize/GetContentSize/SetContentBounds/SetPosition/GetPosition and min/max handling) to scale values and round when setting sizes/positions. Added dpi_utils_windows.h declaration and exposed GetScaleFactorForMonitor in dpi_utils_windows.cpp, included dpi header where needed, and added <cmath> for std::lround. All DPI calls fallback to 1.0 when unavailable; added a comment noting Center uses physical pixels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes nativeapi-flutter#9 — setting minimum/maximum window size on Windows had no effect because the
SetMinimumSizeandSetMaximumSizemethods were empty placeholder implementations.Root Cause
The Windows implementation of
SetMinimumSize/SetMaximumSizeinwindow_windows.cppcontained only placeholder comments acknowledging that the feature "would be handled inWM_GETMINMAXINFOmessage" but never actually implemented it.Solution
This PR properly implements window size constraints on Windows by:
Window::Implmember fieldsWM_GETMINMAXINFOhandler viaWindowMessageDispatcherthat reads the constraints from theWindowobject and setsptMinTrackSize/ptMaxTrackSizeon theMINMAXINFOstructureSWP_FRAMECHANGEDafter setting constraints so the window immediately re-evaluates themThe solution works for both self-created windows and Flutter-hosted windows (via
Window(void*)constructor wrapping the Flutter window handle).Verification