Conversation
kamilsa
approved these changes
Sep 19, 2024
| auto conn_ctx = reinterpret_cast<ConnCtx *>( | ||
| lsquic_conn_get_ctx(lsquic_stream_conn(stream))); | ||
| // NOLINTNEXTLINE(cppcoreguidelines-owning-memory) | ||
| auto stream_ctx = new StreamCtx{self, stream}; |
Contributor
There was a problem hiding this comment.
Is it safe to use new here instead of smart pointers?
Contributor
Author
There was a problem hiding this comment.
lsquic C api accepts void * (size_t) user argument, so it doesn't support C++ destructors,
but it provides callbacks which will cleanup these allocations
igor-egorov
approved these changes
Sep 27, 2024
| std::function<void(outcome::result<std::shared_ptr<QuicConnection>>)>; | ||
| struct Connecting { | ||
| boost::asio::ip::udp::endpoint remote; | ||
| PeerId peer; |
Member
There was a problem hiding this comment.
I guess this also relates to a remote peer
Contributor
Author
There was a problem hiding this comment.
Should we rename to endpoint or spell remote_endpoint?
Signed-off-by: turuslan <turuslan.devbox@gmail.com> # Conflicts: # cmake/Hunter/init.cmake
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsquicto debug problems withnexusQUIC Transport #227