Counting bytes in tcp read write#267
Merged
igor-egorov merged 5 commits intolibp2p:masterfrom Sep 27, 2024
Merged
Conversation
turuslan
approved these changes
Sep 20, 2024
| void TcpConnection::readSome(BytesOut out, | ||
| size_t bytes, | ||
| TcpConnection::ReadCallbackFunc cb) { | ||
| bytes_read_.fetch_add(bytes); |
Contributor
There was a problem hiding this comment.
Should we count bytes we wanted to read/write (call), or actually read/written bytes (callback)?
ErakhtinB
force-pushed
the
1641-fix-sending-wrong-bandwidth-data-to-telemetry
branch
from
60b988d to
5e4f87b
Compare
turuslan
approved these changes
Sep 23, 2024
|
|
||
| namespace libp2p::transport { | ||
|
|
||
| class ByteCounter { |
Contributor
There was a problem hiding this comment.
May name it BandwidthMetric
igor-egorov
approved these changes
Sep 27, 2024
Member
igor-egorov
left a comment
igor-egorov
left a comment
There was a problem hiding this comment.
Please check the comments before merge
| @@ -0,0 +1,32 @@ | |||
| #pragma once | |||
Member
There was a problem hiding this comment.
Suggested change
| #pragma once | |
| /** | |
| * Copyright Quadrivium LLC | |
| * All Rights Reserved | |
| * SPDX-License-Identifier: Apache-2.0 | |
| */ | |
| #pragma once |
| @@ -0,0 +1,26 @@ | |||
| #include <libp2p/transport/tcp/bytes_counter.hpp> | |||
|
|
||
| ByteCounter() = default; | ||
|
|
||
| public: |
Member
There was a problem hiding this comment.
I was surprised that there is no method to reset the counters. Well, that is another possible approach.
ErakhtinB
force-pushed
the
1641-fix-sending-wrong-bandwidth-data-to-telemetry
branch
from
c06c40a to
9b96203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.