Merged
Conversation
mxinden
reviewed
Apr 7, 2021
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
👍 on documenting recommendations. I am not familiar enough with the Rendezvous protocol to approve here. Who is familiar enough to do the review @vasco-santos?
|
|
||
| ## Recommendations for Rendezvous Points configurations | ||
|
|
||
| Rendezvous points should have well defined configurations to enable libp2p nodes running the rendezvous protocol to have friendly defaults, as well as to guarantee the security and efficiency of a Rendezvous point. This will be particularly important in a federation, where rendezvous points should share the same expectations. |
Member
There was a problem hiding this comment.
Nit pick: The rest of the specification is wrapped at 80 characters. Can you do the same here for consistency?
Co-authored-by: Max Inden <mail@max-inden.de>
Member
Author
|
@vyzo is the author, but I would say that anyone in the interest group can also weight in |
77 tasks
Member
|
|
mxinden
approved these changes
Apr 30, 2021
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Merging here since there have been no concerns raised since the last round of pings. Thanks @vasco-santos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds recommendations to the rendezvous spec regarding how a rendezvous point should be configured. These were based on the discussions on the go implementation PR and current code. The discover limit seems a bit higher, but if we have smaller defaults on the client, we can keep it as 1000.
It also fixes an error response status to
E_INVALID_SIGNED_PEER_RECORDsince we are using signed peer records now and this is now yet implemented.