webtransport: move certhash verification to the client#455
Merged
marten-seemann merged 1 commit intowebtransportfrom Sep 20, 2022
Merged
Conversation
This was referenced Sep 16, 2022
Merged
mxinden
approved these changes
Sep 16, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Looks good to me.
but cannot determine which certificate was actually used to establish the connection (this will commonly be the case for browser clients)
Oh, that is unfortunate.
MarcoPolo
approved these changes
Sep 19, 2022
marten-seemann
deleted the
webtransport-client-certhash-verification
branch
marten-seemann
added a commit
that referenced
this pull request
Sep 28, 2022
marten-seemann
added a commit
that referenced
this pull request
Oct 12, 2022
* add a draft for the WebTransport spec * describe the HTTP endpoint * improve introduction Co-authored-by: Melanie Riise <mark.riise26@gmail.com> * use Noise to check end-to-end encryption of the WebTransport connection * define protobuf to encode certificate hashes * use a separate multiaddr component for certificate hashes * remove server mode using CA signed certificates * apply suggestions from code review Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Max Inden <mail@max-inden.de> * webtransport: move certhash verification to the client (#455) * webtransport: remove confusion around Noise handshake completion * webtransport: update certificate generation logic * webtransport: link to Noise Extensions spec * webtransport: move spec to Candidate Recommendation * webtransport: remove misleading mention of hole punching * webtransport: fix typos * webtransport: add interest group * webtransport: add link to Firefox meta-issue * webtransport: soften language around URL multiaddr encoding * webtransport: clarify that WebTransport over HTTP/3 is meant * webtransport: fix typo Co-authored-by: Elena Frank <elena.frank@protonmail.com> * webtransport: clarify certificate regeneration logic * webtransport: fix typos Co-authored-by: Elena Frank <elena.frank@protonmail.com> * webtransport: allow use of CA-signed certificates * address minor issues raised in code review * clarify that servers with a CA-signed certificate don't use /certhash Co-authored-by: Melanie Riise <mark.riise26@gmail.com> Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Max Inden <mail@max-inden.de> Co-authored-by: Elena Frank <elena.frank@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is targeting #404, not master.
This implements the proposal discussed in https://github.com/libp2p/specs/pull/404/files#r968836367.