fix(dotnet-perf): fix dialer bug affecting benchmark runs#23
Merged
dhuseby merged 2 commits intolibp2p:masterfrom Feb 22, 2026
Merged
fix(dotnet-perf): fix dialer bug affecting benchmark runs#23dhuseby merged 2 commits intolibp2p:masterfrom
dhuseby merged 2 commits intolibp2p:masterfrom
Conversation
Co-authored-by: Manu Sheel Gupta <manusheel.edu@gmail.com>
failures and enables QUIC interop tests.
Contributor
Author
|
@flcl42 @seetadev @dhuseby |
dhuseby
approved these changes
Feb 22, 2026
Contributor
dhuseby
left a comment
There was a problem hiding this comment.
LGTM. I ran the perf test local with ./run.sh --impl-ignore !dotnet --force-image-rebuild --yes and it worked flawlessly. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #829
Originally in Test Plans as #831
It extends the changes introduced #829
The original PR resolved a critical issue in the .NET performance benchmarking suite: although the listener multiaddr was correctly stored and fetched from Redis, it was never passed properly into the dialer logic, resulting in dialing attempts without any target address and causing benchmark failures (null/empty multiaddr exceptions).
In addition to preserving that fix, this extended description explains the scope of changes and why they matter:
Background & Root Cause
In the .NET performance benchmarks, the benchmarking flow includes:
However, while the multiaddr was being stored and fetched correctly, it was not passed into the dialer initialization — leading to a failure at runtime where the dialing attempt had no valid multiaddr to connect to. Because the benchmark logic depended on this connection attempt succeeding, the entire benchmark run would throw exceptions and fail prematurely.
Enhacements
Program.csto include explicit checks and assignments.