Fix all test cases, add files for test cases in LFS#4
Conversation
Signed-off-by: Quanyi Ma <eli@patch.sh>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test cases and adds large binary test files to Git LFS for proper handling. It removes a large test_utils module that was downloading files dynamically and instead stores the required pack files directly in LFS.
- Moved zstdelta implementation from separate file to mod.rs for better organization
- Replaced dynamic test file downloads with LFS-stored test files
- Updated all test file paths to use proper manifest directory references
- Fixed several test configurations and removed ignore attributes
Reviewed Changes
Copilot reviewed 24 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/zstdelta/mod.rs | Moved zstdelta implementation directly into mod.rs |
| src/lib.rs | Removed test_utils module for dynamic file downloads |
| src/internal/pack/decode.rs | Updated test file paths and fixed async test patterns |
| src/internal/pack/encode.rs | Cleaned up file path handling and comments |
| tests/data/packs/*.pack | Added LFS pointers for large pack files |
| .gitattributes | Added LFS configuration for pack files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // a should be ejected | ||
| let r = cache.get(&hash_a.to_string()); | ||
| assert!(r.is_some()); | ||
| assert!(r.is_none()); |
There was a problem hiding this comment.
The test logic appears incorrect. After ejecting an item from the cache, the assertion expects the item to be None, but the comment states 'a should be ejected' suggesting it should be present. This contradicts the expected behavior.
|
|
||
| #[test] | ||
| #[ignore] // Take too long time | ||
| #[test]// Take too long time |
There was a problem hiding this comment.
Missing space after #[test] attribute. Should be #[test] // Take too long time
| #[test]// Take too long time | |
| #[test] // Take too long time |
Signed-off-by: Quanyi Ma <eli@patch.sh>
No description provided.